Added support for scripts in file system#3
Open
rparakhiya wants to merge 5 commits intoimproving:masterfrom
Open
Added support for scripts in file system#3rparakhiya wants to merge 5 commits intoimproving:masterfrom
rparakhiya wants to merge 5 commits intoimproving:masterfrom
Conversation
Author
|
I'd be happy to discuss any changes or issues identified. Please feel free to reach out. |
|
Looks like you never got anywhere with merging this in. Are you using this code currently? I'm definitely interested in the file system source for hashed scripts. |
Author
|
@piwaf We are not actively using it for other reasons, but we tested it briefly and it got us going with scripts in file system. Let me know what you think about the changes and we can move it forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Breaking Change:
DbUpdateris an abstract class now. To use specific script provider, there are factory methods:DbUpdater.UsingEmbeddedScriptsandDbUpdater.UsingScriptsInFileSystem.UsingEmbeddedScriptsfactory method requires same parameters as previously. Hence, for clients it would be a quick change.